Skip to content

ConCatLayer#189

Merged
allnes merged 5 commits into
mainfrom
Semyon1104/Concat_Layer
Aug 8, 2025
Merged

ConCatLayer#189
allnes merged 5 commits into
mainfrom
Semyon1104/Concat_Layer

Conversation

@Semyon1104

Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread test/single_layer/test_concatlayer.cpp Outdated
#include <vector>

#include "gtest/gtest.h"
#include "layers/ConCatLayer.hpp"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest naming it the same way as class is named: ConcatLayer.hpp

#include "layers/Tensor.hpp"

using namespace it_lab_ai;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add tests for 0/1 inputs

@allnes allnes enabled auto-merge (squash) August 8, 2025 16:31
@allnes allnes disabled auto-merge August 8, 2025 16:31
@allnes allnes merged commit 68ec25c into main Aug 8, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants